Issue 740323002: Incorporating nweiz' feedback. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(71)

My Issues | Starred Open | Closed | All

Issue 740323002: Incorporating nweiz' feedback. (Closed)

Created:
6 years, 1 month ago by wibling

Modified:
6 years, 1 month ago

Reviewers:
nweiz, Søren Gjesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Incorporating nweiz' feedback. BUG= R=kustermann@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=41850

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	pkg/unittest/test/with_test_environment_test.dart	View		1 chunk	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wibling

Committed patchset #1 (id:1) manually as 41850 (presubmit successful).

6 years, 1 month ago (2014-11-20 13:43:25 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698