Hook up dependency overrides to the rest of pub.

Hook up dependency overrides to the rest of pub.

- Parse them in pubspec.
- Pass them to solver.
- Warn when they are used.
- Error on publish.

BUG=https://code.google.com/p/dart/issues/detail?id=8566
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30376

[Bob Nystrom, 2013-11-16 00:47:28]

Aside from docs, they should be pretty good to go after this.

[nweiz, 2013-11-16 01:04:00]

lgtm

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:150: log.warning("- $override");
--verbose/--trace logs look better if a single log entry is passed as a single
newline-separated argument to [warning].

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:93:
Iterable<PackageDep> overrides, List<String> useLatest)
[overrides] should no longer be passed in here, right?

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/validator/dependency_override.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/validator/dependency_override.dart:23: 'its
dependencies\nthat users will have when they use it.');
Style nit: I'd format this like so:

    'Your pubspec.yaml must not have a "dependency_overrides" field.\n'
    'This ensures you test your package against the same versions of '
        'its dependencies\n'
    'that users will have when they use it.'

[Bob Nystrom, 2013-11-18 21:51:54]

Committed patchset #2 manually as r30376 (presubmit successful).

[Bob Nystrom, 2013-11-18 21:53:45]

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:150: log.warning("- $override");
On 2013/11/16 01:04:00, nweiz wrote:
> --verbose/--trace logs look better if a single log entry is passed as a single
> newline-separated argument to [warning].

Done.

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:93:
Iterable<PackageDep> overrides, List<String> useLatest)
On 2013/11/16 01:04:00, nweiz wrote:
> [overrides] should no longer be passed in here, right?

Right. Merge bug. :( Fixed.

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/validator/dependency_override.dart (right):

https://codereview.chromium.org/74013007/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/validator/dependency_override.dart:23: 'its
dependencies\nthat users will have when they use it.');
On 2013/11/16 01:04:00, nweiz wrote:
> Style nit: I'd format this like so:
> 
>     'Your pubspec.yaml must not have a "dependency_overrides" field.\n'
>     'This ensures you test your package against the same versions of '
>         'its dependencies\n'
>     'that users will have when they use it.'

Done.