Issue 739643003: Cache ElementLocation instance and index key/location ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739643003: Cache ElementLocation instance and index key/location ids. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Cache ElementLocation instance and index key/location ids. This saves us about 9% of time, as the previous CL. From 22294 ms to 20040 ms. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41814

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -9 lines)			Patch
	M	pkg/analysis_server/lib/src/services/index/store/codec.dart	View		3 chunks	+37 lines, -8 lines	0 comments	Download
	M	pkg/analyzer/lib/src/generated/element.dart	View		3 chunks	+26 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 1 month ago (2014-11-18 23:02:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41814 (presubmit successful).