Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739513002: Incremental compilation of removed class. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Incremental compilation of removed class. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41888

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merged with r41887. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -43 lines) Patch
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 5 chunks +127 lines, -43 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
6 years, 1 month ago (2014-11-18 11:23:51 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/739513002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/739513002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode766 dart/pkg/dart2js_incremental/lib/library_updater.dart:766: bool get isRemoval => true; Not needed. Is ...
6 years, 1 month ago (2014-11-19 12:43:53 UTC) #3
ahe
Committed patchset #2 (id:20001) manually as 41888 (presubmit successful).
6 years, 1 month ago (2014-11-21 09:59:25 UTC) #4
ahe
For got to address comments. Will follow up.
6 years, 1 month ago (2014-11-21 10:05:45 UTC) #5
ahe
6 years, 1 month ago (2014-11-21 10:47:46 UTC) #6
Message was sent while issue was closed. 
Thank you, Johnni!

I've followed up on your comments in https://codereview.chromium.org/745583003/.

Cheers,
Peter

https://codereview.chromium.org/739513002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/739513002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/library_updater.dart:766: bool get isRemoval =>
true;
On 2014/11/19 12:43:53, Johnni Winther wrote:
> Not needed. Is already declared in RemovalUpdate.

Done.

https://codereview.chromium.org/739513002/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/739513002/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update_test.dart:819: // isn't.
Investigate and write test.
On 2014/11/19 12:43:53, Johnni Winther wrote:
> All a test in which a static property of C is used.

Done.

Powered by Google App Engine
This is Rietveld 408576698