Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 739153002: Make the ConsoleSink call methos argument optional. (Closed)

Created:
6 years, 1 month ago by Søren Gjesse
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the ConsoleSink call methos argument optional. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M sdk/lib/io/console.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/console_script.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/console_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
6 years, 1 month ago (2014-11-19 13:18:36 UTC) #1
Ivan Posva
LGTM -ip
6 years, 1 month ago (2014-11-19 16:44:42 UTC) #2
Søren Gjesse
6 years, 1 month ago (2014-11-20 07:51:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698