Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 738863005: Respect order dependencies in ImplicitConstructorBuilder. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Respect order dependencies in ImplicitConstructorBuilder. Since implicit constructors for a mixin application are based on the constructors of the superclass, we must build implicit constructors for superclasses before we build them for derived classes. BUG=dartbug.com/21600 R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42052

Patch Set 1 #

Patch Set 2 : Sort unit/class members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -70 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 8 chunks +182 lines, -68 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
6 years ago (2014-12-01 21:30:08 UTC) #2
scheglov
LGTM, but I'd like Brian to take a lot on it too.
6 years ago (2014-12-01 21:41:20 UTC) #3
Paul Berry
6 years ago (2014-12-01 21:42:06 UTC) #5
Brian Wilkerson
LGTM
6 years ago (2014-12-01 22:08:55 UTC) #6
Paul Berry
6 years ago (2014-12-01 22:35:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698