Issue 738343002: Drop return types in DeclarationMatcher visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 738343002: Drop return types in DeclarationMatcher visitor. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Drop return types in DeclarationMatcher visitor. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41853

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -52 lines)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		21 chunks	+52 lines, -52 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Looks really strange to me, but I suppose it's consistent with Dart's overall style. https://codereview.chromium.org/738343002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart ...

6 years, 1 month ago (2014-11-20 15:43:05 UTC) #2

scheglov

https://codereview.chromium.org/738343002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/738343002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode138 pkg/analyzer/lib/src/generated/incremental_resolver.dart:138: return null; On 2014/11/20 15:43:05, Brian Wilkerson wrote: > ...

6 years, 1 month ago (2014-11-20 15:58:49 UTC) #3

scheglov

6 years, 1 month ago (2014-11-20 15:59:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41853 (presubmit successful).

Expand Messages | Collapse Messages