Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 738183002: Tests for matching classes. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tests for matching classes. Matching type parameters is not implemeneted yet. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41841

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -52 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 8 chunks +75 lines, -52 lines 2 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 4 chunks +180 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 1 month ago (2014-11-19 21:06:32 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/738183002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/738183002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode86 pkg/analyzer/lib/src/generated/incremental_resolver.dart:86: } on _DeclarationMismatchException catch (exception, st) { Not ...
6 years, 1 month ago (2014-11-19 23:07:22 UTC) #2
scheglov
https://codereview.chromium.org/738183002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/738183002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode86 pkg/analyzer/lib/src/generated/incremental_resolver.dart:86: } on _DeclarationMismatchException catch (exception, st) { On 2014/11/19 ...
6 years, 1 month ago (2014-11-20 05:27:31 UTC) #3
scheglov
6 years, 1 month ago (2014-11-20 05:27:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698