Issue 73783002: Make SendPortImpl_internalSend not take a reply port as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73783002: Make SendPortImpl_internalSend not take a reply port as argument. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make SendPortImpl_internalSend not take a reply port as argument. The reply port is still there in the internal Message structure, where it is used by control messages. BUG= http://dartbug.com/14731 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=30302

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove TODO #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
M	runtime/lib/isolate.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

https://codereview.chromium.org/73783002/diff/1/runtime/lib/isolate_patch.dart File runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/73783002/diff/1/runtime/lib/isolate_patch.dart#newcode145 runtime/lib/isolate_patch.dart:145: // TODO(14731): Remove replyId argument. Remove the TODO.

7 years, 1 month ago (2013-11-15 10:19:14 UTC) #3

Lasse Reichstein Nielsen

7 years, 1 month ago (2013-11-15 11:28:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30302 (presubmit successful).

Expand Messages | Collapse Messages