Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 737673002: add source changed event stream (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -77 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 13 chunks +163 lines, -46 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 14 chunks +290 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 1 month ago (2014-11-18 05:47:26 UTC) #2
Brian Wilkerson
LGTM once the missing Event class is added. https://codereview.chromium.org/737673002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/737673002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode987 pkg/analyzer/lib/src/generated/engine.dart:987: StreamController<ChangeSet> ...
6 years, 1 month ago (2014-11-18 15:22:19 UTC) #3
danrubel
https://codereview.chromium.org/737673002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/737673002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode987 pkg/analyzer/lib/src/generated/engine.dart:987: StreamController<ChangeSet> _onSourcesChangedController; On 2014/11/18 15:22:19, Brian Wilkerson wrote: > ...
6 years, 1 month ago (2014-11-19 01:02:17 UTC) #4
danrubel
6 years, 1 month ago (2014-11-19 01:02:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698