Issue 737353002: cps-ir: Implement boolean conversion in and use it to implement '&&', '||', and '?:'.

Issue 737353002: cps-ir: Implement boolean conversion in and use it to implement '&&', '||', and '?:'. (Closed)

Created:
6 years, 1 month ago by karlklose

Modified:
6 years, 1 month ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

cps-ir: Implement boolean conversion in and use it to implement '&&', '||', and '?:'. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41884

Patch Set 2 : Do not add new Boolify node; subclass the builder instead. #

Patch Set 5 : Rebase to new test infrastructure. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -10 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 2 3 4	3 chunks	+13 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	1 2 3 4	3 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	1 2 3	2 chunks	+37 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	tests/compiler/dart2js/js_backend_cps_ir_operators.dart	View	1 2 3 4	1 chunk	+45 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_test.dart	View	1 2 3 4	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sigurdm

lgtm https://codereview.chromium.org/737353002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/737353002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode15 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:15: import 'package:compiler/src/js_backend/codegen/unsugar.dart'; Package import https://codereview.chromium.org/737353002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode631 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:631: abstract class ...

6 years, 1 month ago (2014-11-20 12:47:28 UTC) #2

karlklose

PTAL, I removed the conversion node and implemented the rewrite in the cps->conversion for now. ...

6 years, 1 month ago (2014-11-21 08:30:55 UTC) #3

karlklose

6 years, 1 month ago (2014-11-21 09:07:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as 41884 (presubmit successful).

Expand Messages | Collapse Messages