Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 736923002: Revert revision 41812 "Let docgen detect a dart-sdk directory that's differently named" (Closed)

Created:
6 years, 1 month ago by ricow1
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert revision 41812 "Let docgen detect a dart-sdk directory that's differently named" The vm build is incremental, and on bleeding edge the revision number is part of the version number. So if a cl lands that triggers a rebuild of the api docs - but not of the vm, the check for vmVersion.startsWith(version) will report false. This is exactly what happened here: http://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/400 The change from sgjesse@ : https://code.google.com/p/dart/source/detail?r=41821 Triggered a rebuild of the api docs, but the vm remained unchanged with a version of: 1.8.0-edge.41820 The version of the build was: 1.8.0-edge.41821 Committed: https://code.google.com/p/dart/source/detail?r=41824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M pkg/docgen/lib/src/package_helpers.dart View 2 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 1 month ago (2014-11-19 09:17:26 UTC) #1
ricow1
tbr
6 years, 1 month ago (2014-11-19 09:26:53 UTC) #2
ricow1
Committed patchset #1 (id:1) manually as r41824 (presubmit successful).
6 years, 1 month ago (2014-11-19 09:27:09 UTC) #3
Søren Gjesse
lgtm
6 years, 1 month ago (2014-11-19 10:36:21 UTC) #4
Alan Knight
6 years, 1 month ago (2014-11-19 18:50:39 UTC) #5
Message was sent while issue was closed.
Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698