Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 736813002: Fix incremental parsing of function literals in initializer lists. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix incremental parsing of function literals in initializer lists. One of the areas in which the Dart grammar is context sensitive is the fact that function literals are disallowed inside initializer lists (unless they are enclosed inside (), [], {}, or "${}"). To deal with this context sentitivity in incremental parsing, we must rebuild the correct parser state for the subexpression we are going to re-parse before parsing it. We do so with a new visitor, IncrementalParseStateBuilder. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -10 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +97 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +53 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-18 22:35:44 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-18 22:44:58 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-18 22:50:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698