Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 736603005: Rollback r41807. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rollback r41807. As discussed, it is not compatible with the incremental analysis. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -234 lines) Patch
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 4 chunks +56 lines, -61 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 4 chunks +12 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 6 chunks +146 lines, -111 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +16 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +65 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-18 18:44:29 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-18 18:49:22 UTC) #2
scheglov
6 years, 1 month ago (2014-11-18 18:50:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698