Issue 736113002: Restructure inlining of Bigint accessors, use consistent approach, fixes a potential crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 736113002: Restructure inlining of Bigint accessors, use consistent approach, fixes a potential crash. (Closed)

Created:
6 years, 1 month ago by srdjan

Modified:
6 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Restructure inlining of Bigint accessors, use consistent approach, fixes a potential crash. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=41840

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -57 lines)			Patch
M	runtime/lib/bigint.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+51 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

6 years, 1 month ago (2014-11-19 22:28:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41840 (presubmit successful).