Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 735723003: Implement enum types in VM (Closed)

Created:
6 years, 1 month ago by hausner
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, kasperl, gbracha
Visibility:
Public.

Description

Implement enum types in VM Fully support enum types as per language spec version 1.6. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41815

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -261 lines) Patch
M runtime/lib/core_patch.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/class_finalizer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 3 chunks +58 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 1 chunk +15 lines, -15 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 7 chunks +238 lines, -238 lines 2 comments Download
M runtime/vm/object.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 8 chunks +231 lines, -5 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/token.h View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/enum_syntax_test.dart View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hausner
6 years, 1 month ago (2014-11-18 19:11:34 UTC) #2
srdjan
lgtm https://codereview.chromium.org/735723003/diff/20001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/735723003/diff/20001/runtime/vm/class_finalizer.cc#newcode2380 runtime/vm/class_finalizer.cc:2380: if (!ordinal_value.IsSmi()) continue; Maybe add comment how it ...
6 years, 1 month ago (2014-11-18 21:19:18 UTC) #3
hausner
Committed patchset #3 (id:40001) manually as r41815 (presubmit successful).
6 years, 1 month ago (2014-11-18 23:10:21 UTC) #4
hausner
Thanks. Also added tests to check whether enum types are used as super type, interface ...
6 years, 1 month ago (2014-11-18 23:14:07 UTC) #5
Florian Schneider
https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recognizer.h#newcode31 runtime/vm/method_recognizer.h:31: V(_TypedList, _setInt8, ByteArrayBaseSetInt8, 783880753) \ dbc: What's wrong with ...
6 years, 1 month ago (2014-11-19 12:42:29 UTC) #7
hausner
https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recognizer.h#newcode31 runtime/vm/method_recognizer.h:31: V(_TypedList, _setInt8, ByteArrayBaseSetInt8, 783880753) \ On 2014/11/19 12:42:29, Florian ...
6 years, 1 month ago (2014-11-19 16:47:00 UTC) #8
Florian Schneider
6 years, 1 month ago (2014-11-19 16:49:38 UTC) #9
Message was sent while issue was closed. 
On 2014/11/19 16:47:00, hausner wrote:
>
https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recogn...
> File runtime/vm/method_recognizer.h (right):
> 
>
https://codereview.chromium.org/735723003/diff/40001/runtime/vm/method_recogn...
> runtime/vm/method_recognizer.h:31: V(_TypedList, _setInt8,
ByteArrayBaseSetInt8,
> 783880753)                     \
> On 2014/11/19 12:42:29, Florian Schneider wrote:
> > dbc: What's wrong with our fingerprint computation that simply adding the
> > EnumHelper class to core changes a ton of fingerprints on unrelated classes?
> 
> It's the added keyword 'enum' that caused the token stream (and thus the
> fingerprint) of the functions to change.

Oh yes, I see. Thanks for the clarification.

Powered by Google App Engine
This is Rietveld 408576698