Incremental compilation of added instance fields.

Incremental compilation of added instance fields.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41905

[ahe, 2014-11-19 13:44:31]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-11-21 14:23:05]

lgtm

https://codereview.chromium.org/735303002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/735303002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:263: void addFields(
Add documentation, especially for [syntheticContainer].

[ahe, 2014-11-21 15:48:47]

Thank you, Johnni!

https://codereview.chromium.org/735303002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/735303002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:263: void addFields(
On 2014/11/21 14:23:05, Johnni Winther wrote:
> Add documentation, especially for [syntheticContainer].

Done, added:

  /// Called when a field in [definition] has changed.
  ///
  /// There's no direct link from a [PartialFieldList] to its implied
  /// [FieldElementX], so instead we use [syntheticContainer], the (synthetic)
  /// container created by [canReuseLibrary], or [canReuseClass] (through
  /// [PartialClassElement.parseNode]). This container is scanned looking for
  /// fields whose declaration site is [definition].
  // TODO(ahe): It would be nice if [computeDifference] returned this
  // information directly.

[ahe, 2014-11-21 15:52:49]

Committed patchset #5 (id:40002) manually as 41905 (presubmit successful).