Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 73523004: Initial polymer_expressions benchmarks (Closed)

Created:
7 years, 1 month ago by justinfagnani
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial polymer_expressions benchmarks BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30320

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
A + pkg/polymer_expressions/benchmark/all.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A pkg/polymer_expressions/benchmark/eval.dart View 1 chunk +41 lines, -0 lines 1 comment Download
A pkg/polymer_expressions/benchmark/parse.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
justinfagnani
We probably want more expressions in the eval benchmark, particularly observable values and filters. Other ...
7 years, 1 month ago (2013-11-15 22:08:53 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/73523004/diff/1/pkg/polymer_expressions/benchmark/eval.dart File pkg/polymer_expressions/benchmark/eval.dart (right): https://codereview.chromium.org/73523004/diff/1/pkg/polymer_expressions/benchmark/eval.dart#newcode27 pkg/polymer_expressions/benchmark/eval.dart:27: final expr = parse('foo.bar.baz'); just a rough sense ...
7 years, 1 month ago (2013-11-15 22:32:58 UTC) #2
Jennifer Messerly
On 2013/11/15 22:32:58, John Messerly wrote: > just a rough sense based on what I've ...
7 years, 1 month ago (2013-11-15 22:33:43 UTC) #3
justinfagnani
7 years, 1 month ago (2013-11-15 22:44:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r30320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698