Issue 734323003: Use Object.create instead of a tmp-function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 734323003: Use Object.create instead of a tmp-function. (Closed)

Created:
6 years, 1 month ago by ahe

Modified:
6 years, 1 month ago

Reviewers:
Johnni Winther, floitsch, sra1

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use Object.create instead of a tmp-function. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41823

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	dart/sdk/lib/_internal/compiler/js_lib/js_helper.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

Committed patchset #1 (id:1) manually as 41823 (presubmit successful).

6 years, 1 month ago (2014-11-19 09:20:48 UTC) #5

sra1

This CL has a big perf hit (-45%, -26% -8%) on some benchmarks. Can it ...

6 years, 1 month ago (2014-11-21 05:04:11 UTC) #7

ahe

6 years, 1 month ago (2014-11-21 05:45:11 UTC) #8

Message was sent while issue was closed.

On 2014/11/21 05:04:11, sra1 wrote:
> This CL has a big perf hit (-45%, -26% -8%) on some benchmarks.
> Can it be reverted?

I'll revert the part about using Object.create instead of tmp function.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages