Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 733463002: Add console to dart:io for synchronus writing to stdout and stderr (Closed)

Created:
6 years, 1 month ago by Søren Gjesse
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add console to dart:io for synchronus writing to stdout and stderr This is provided as a fallback for applications relying synchronus writing to stdout/stderr, which was changed to be async in r41436. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41801

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -0 lines) Patch
A sdk/lib/io/console.dart View 1 chunk +97 lines, -0 lines 4 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A tests/standalone/io/console_script.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A tests/standalone/io/console_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
6 years, 1 month ago (2014-11-14 12:58:49 UTC) #1
Paul Berry
DBC https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart File sdk/lib/io/console.dart (right): https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart#newcode44 sdk/lib/io/console.dart:44: * This class had a call method so ...
6 years, 1 month ago (2014-11-14 14:06:45 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart File sdk/lib/io/console.dart (right): https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart#newcode54 sdk/lib/io/console.dart:54: void call(String message) => _sink.writeln(message); Wondering whether ...
6 years, 1 month ago (2014-11-18 05:54:44 UTC) #3
Søren Gjesse
https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart File sdk/lib/io/console.dart (right): https://codereview.chromium.org/733463002/diff/1/sdk/lib/io/console.dart#newcode44 sdk/lib/io/console.dart:44: * This class had a call method so you ...
6 years, 1 month ago (2014-11-18 13:51:35 UTC) #4
Søren Gjesse
6 years, 1 month ago (2014-11-18 14:08:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698