cps-ir: Add a test for codegeneration.

cps-ir: Add a test for codegeneration.

This CL includes CL 723493002 and adds a test case for it.

R=floitsch@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41782

[karlklose, 2014-11-17 14:46:45]

Patchset #4 (id:60001) has been deleted

[karlklose, 2014-11-17 14:46:48]

Patchset #3 (id:40001) has been deleted

[floitsch, 2014-11-17 15:03:30]

LGTM.

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/task.dart (right):

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/task.dart:152: CodeGenerator codeGen =
new CodeGenerator(new Glue(compiler), work.registry);
long line.

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1818:
push(backend.emitter.constantReference(node.constant));
Please keep the code.
I tried to remove it in a separate CL, and it broke the tests.

See https://codereview.chromium.org/721093003/

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:36:
Expect.isTrue(compiler.assembledCode != null);
indent+, or indent- in the next line.

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:36:
Expect.isTrue(compiler.assembledCode != null);
Expect.isNotNull(...)

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:40: Expect.isTrue(false);
Expect.fail(...)

[karlklose, 2014-11-17 16:11:43]

Committed patchset #6 (id:140001) manually as 41782 (presubmit successful).

[karlklose, 2014-11-17 16:11:58]

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/task.dart (right):

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/task.dart:152: CodeGenerator codeGen =
new CodeGenerator(new Glue(compiler), work.registry);
On 2014/11/17 15:03:30, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/733053004/diff/80001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1818:
push(backend.emitter.constantReference(node.constant));
On 2014/11/17 15:03:30, floitsch wrote:
> Please keep the code.
> I tried to remove it in a separate CL, and it broke the tests.
> 
> See https://codereview.chromium.org/721093003/

That was a merge error, reverted.

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:36:
Expect.isTrue(compiler.assembledCode != null);
On 2014/11/17 15:03:30, floitsch wrote:
> Expect.isNotNull(...)

Done.

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:36:
Expect.isTrue(compiler.assembledCode != null);
On 2014/11/17 15:03:30, floitsch wrote:
> Expect.isNotNull(...)

Done.

https://codereview.chromium.org/733053004/diff/80001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:40: Expect.isTrue(false);
On 2014/11/17 15:03:30, floitsch wrote:
> Expect.fail(...)

Done.