Issue 732573002: Fix overflow check in the Smi::ShiftOp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732573002: Fix overflow check in the Smi::ShiftOp. (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
6 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix overflow check in the Smi::ShiftOp. It did not work correctly for the corner case like -1 << 63. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=41740

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

6 years, 1 month ago (2014-11-14 13:20:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41740 (presubmit successful).