Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 732533002: Add HTML test with two dart scripts on one page. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1, sigurdm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add HTML test with two dart scripts on one page. BUG=dartbug.com/20698 R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41794

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M tests/html/html.status View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/scripts_test_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/html/two_scripts_htmltest.html View 1 chunk +7 lines, -6 lines 0 comments Download
A + tests/html/two_scripts_test_first.dart View 1 chunk +6 lines, -5 lines 2 comments Download
A + tests/html/two_scripts_test_second.dart View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
6 years, 1 month ago (2014-11-14 11:44:50 UTC) #2
Bill Hesse
6 years, 1 month ago (2014-11-14 12:16:54 UTC) #4
sigurdm
LGTM https://codereview.chromium.org/732533002/diff/1/tests/html/two_scripts_test_first.dart File tests/html/two_scripts_test_first.dart (right): https://codereview.chromium.org/732533002/diff/1/tests/html/two_scripts_test_first.dart#newcode9 tests/html/two_scripts_test_first.dart:9: window.postMessage('first_global', '*'); Why do we have a "local" ...
6 years, 1 month ago (2014-11-18 08:19:55 UTC) #5
Bill Hesse
https://codereview.chromium.org/732533002/diff/1/tests/html/two_scripts_test_first.dart File tests/html/two_scripts_test_first.dart (right): https://codereview.chromium.org/732533002/diff/1/tests/html/two_scripts_test_first.dart#newcode9 tests/html/two_scripts_test_first.dart:9: window.postMessage('first_global', '*'); On 2014/11/18 08:19:55, sigurdm wrote: > Why ...
6 years, 1 month ago (2014-11-18 09:16:47 UTC) #6
Bill Hesse
6 years, 1 month ago (2014-11-18 09:27:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698