add ContextsChangedEvent

add ContextsChangedEvent

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41786

[danrubel, 2014-11-17 15:11:30]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-11-17 15:58:34]

LGTM

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:122: * [addedContexts] lists
contexts that were added to the server.
These comments don't follow the form you used elsewhere. How about "The contexts
that were added to the server.", etc.

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:137: List<AnalysisContext>
changed: null, List<AnalysisContext> removed: null}) {
How about something like:

ContextsChangedEvent({this.added: AnalysisContext.EMPTY_LIST, ...});

That has the advantage that we could share the same empty list for all events,
hence creating fewer temporary objects.

[danrubel, 2014-11-17 17:10:15]

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:122: * [addedContexts] lists
contexts that were added to the server.
On 2014/11/17 15:58:34, Brian Wilkerson wrote:
> These comments don't follow the form you used elsewhere. How about "The
contexts
> that were added to the server.", etc.

Done.

https://codereview.chromium.org/732093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:137: List<AnalysisContext>
changed: null, List<AnalysisContext> removed: null}) {
On 2014/11/17 15:58:34, Brian Wilkerson wrote:
> How about something like:
> 
> ContextsChangedEvent({this.added: AnalysisContext.EMPTY_LIST, ...});
> 
> That has the advantage that we could share the same empty list for all events,
> hence creating fewer temporary objects.

Good point. Done.

[danrubel, 2014-11-17 17:15:37]

Committed patchset #3 (id:40001) manually as 41786 (presubmit successful).