Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 732083002: Implement adding methods. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Implement adding methods. This makes it possible to implement signature changes as remove followed by add. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41886

Patch Set 1 : #

Patch Set 2 : Merged with r41825 #

Patch Set 3 : Merged with r41885 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -21 lines) Patch
M dart/pkg/compiler/lib/src/elements/modelx.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/scanner/listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 10 chunks +72 lines, -21 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
6 years, 1 month ago (2014-11-17 14:54:53 UTC) #3
Johnni Winther
lgtm
6 years, 1 month ago (2014-11-19 11:35:37 UTC) #4
ahe
6 years, 1 month ago (2014-11-21 09:54:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 41886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698