Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 73203002: Better feature-testing for Chrome browser (Closed)

Created:
7 years, 1 month ago by sra1
Modified:
7 years ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Jennifer Messerly
Visibility:
Public.

Description

Better feature-testing for Chrome browser R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=30649

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M sdk/lib/_internal/lib/native_helper.dart View 1 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
Hi Alan, The tests don't work, but does the other change fix the problem?
7 years, 1 month ago (2013-11-22 03:10:38 UTC) #1
Alan Knight
Well, it changes the problem :-)
7 years ago (2013-11-22 18:57:43 UTC) #2
Alan Knight
lgtm. I still get some other problems, but they seem unrelated.
7 years ago (2013-11-25 22:25:05 UTC) #3
sra1
7 years ago (2013-11-25 22:29:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r30649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698