Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 731503002: cps-ir: Split up main codegen and add a bailout exception to print out (Closed)

Created:
6 years, 1 month ago by karlklose
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

cps-ir: Split up main codegen and add a bailout exception to print out more information. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41780

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Refactor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -71 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 2 2 chunks +89 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
karlklose
6 years, 1 month ago (2014-11-17 10:03:00 UTC) #2
floitsch
LGTM.
6 years, 1 month ago (2014-11-17 14:36:48 UTC) #3
karlklose
6 years, 1 month ago (2014-11-17 15:48:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698