Issue 731313004: Issue 21618. Fix for empty code for 'dynamic' type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 731313004: Issue 21618. Fix for empty code for 'dynamic' type. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 21618. Fix for empty code for 'dynamic' type. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21618 Committed: https://code.google.com/p/dart/source/detail?r=41838

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -17 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		8 chunks	+20 lines, -17 lines	1 comment	Download
	M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/731313004/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/731313004/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode630 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:630: _appendType(sb, fieldType, groupId: 'TYPE', orVar: true); The group ...

6 years, 1 month ago (2014-11-19 15:58:19 UTC) #2

scheglov

6 years, 1 month ago (2014-11-19 17:42:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41838 (presubmit successful).

Expand Messages | Collapse Messages