Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 730783002: Make constant lists immutable (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 34 chunks +67 lines, -67 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-15 01:24:03 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-15 01:29:13 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-15 01:34:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698