Remove use of IterableMixinWorkaround from _List, _ImmutableList and _GrowableList.

VM: Remove use of IterableMixinWorkaround from _List, _ImmutableList and _GrowableList.

_List, _ImmutableList and _GrowableList now extend ListBase which uses ListMixin.

Note that typed data lists are still using IterableMixinWorkaround for now.
They will be changed in a separate CL since it involves a few more changes
to the VM.

BUG=dartbug.com/13647
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42061

[Florian Schneider, 2014-11-14 14:51:09]

fschneider@google.com changed reviewers:
+ lrn@google.com, srdjan@google.com

[Lasse Reichstein Nielsen, 2014-11-17 13:32:09]

lgtm

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:7: class _List<E> extends ListBase<E> {
You might be able to use FixedLengthListBase here, and remove the throwing
functions too.

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:126: 
These three should be in ListBase too.

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:174: }
Most of these methods are probably identical to the ones in ListBase. 
(But it's not important now, we can always remove them later).

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:203: class _ImmutableList<E> extends ListBase<E> {
And maybe extend UnmodifableListBase here.

https://codereview.chromium.org/730543002/diff/40001/runtime/vm/debugger_api_...
File runtime/vm/debugger_api_impl_test.cc (right):

https://codereview.chromium.org/730543002/diff/40001/runtime/vm/debugger_api_...
runtime/vm/debugger_api_impl_test.cc:2263: super_type =
Dart_GetSupertype(super_type);
Brilliant hard-coding!
Is this necessary (i.e., is it an assumption used somewhere else?)

[Florian Schneider, 2014-11-17 15:26:37]

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:7: class _List<E> extends ListBase<E> {
On 2014/11/17 13:32:08, Lasse Reichstein Nielsen wrote:
> You might be able to use FixedLengthListBase here, and remove the throwing
> functions too.

Good point. Done.

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:126: 
On 2014/11/17 13:32:08, Lasse Reichstein Nielsen wrote:
> These three should be in ListBase too.

Done.

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:174: }
On 2014/11/17 13:32:08, Lasse Reichstein Nielsen wrote:
> Most of these methods are probably identical to the ones in ListBase. 
> (But it's not important now, we can always remove them later).

Done. I replace a couple of methods. There are some subtle diffs in
first/last/single in how the length is compared with 0/1 which I'd like to
reconcile first.

https://codereview.chromium.org/730543002/diff/40001/runtime/lib/array.dart#n...
runtime/lib/array.dart:203: class _ImmutableList<E> extends ListBase<E> {
On 2014/11/17 13:32:08, Lasse Reichstein Nielsen wrote:
> And maybe extend UnmodifableListBase here.

Done.

https://codereview.chromium.org/730543002/diff/40001/runtime/vm/debugger_api_...
File runtime/vm/debugger_api_impl_test.cc (right):

https://codereview.chromium.org/730543002/diff/40001/runtime/vm/debugger_api_...
runtime/vm/debugger_api_impl_test.cc:2263: super_type =
Dart_GetSupertype(super_type);
On 2014/11/17 13:32:08, Lasse Reichstein Nielsen wrote:
> Brilliant hard-coding!
> Is this necessary (i.e., is it an assumption used somewhere else?)

I don't think it is used. I will happily remove it and just check that
GetSuperType returns a valid value (no error).

[Ivan Posva, 2014-11-18 07:24:17]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2014-11-18 07:24:18]

-Ivan

https://codereview.chromium.org/730543002/diff/60001/tests/lib/mirrors/interc...
File tests/lib/mirrors/intercepted_object_test.dart (right):

https://codereview.chromium.org/730543002/diff/60001/tests/lib/mirrors/interc...
tests/lib/mirrors/intercepted_object_test.dart:21: cls =
cls.superclass.superclass.mixin;
This is similar hard coding as was removed in other places.

How is this supposed to work in dart2js?

[Florian Schneider, 2014-11-18 10:20:19]

https://codereview.chromium.org/730543002/diff/60001/tests/lib/mirrors/interc...
File tests/lib/mirrors/intercepted_object_test.dart (right):

https://codereview.chromium.org/730543002/diff/60001/tests/lib/mirrors/interc...
tests/lib/mirrors/intercepted_object_test.dart:21: cls =
cls.superclass.superclass.mixin;
On 2014/11/18 07:24:18, Ivan Posva wrote:
> This is similar hard coding as was removed in other places.
> 
> How is this supposed to work in dart2js?

Yes, but it is just a test which can easily be adapted, and it already works,
since this path is not taken with dart2js.

[Florian Schneider, 2014-12-02 10:38:59]

Committed patchset #4 (id:60001) manually as r42061 (presubmit successful).