Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 730533003: Code clean-up and minor bug fix (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -1308 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 291 chunks +585 lines, -1257 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +2 lines, -27 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/enum_test.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 3 chunks +80 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-14 15:44:35 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-14 16:00:46 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-14 16:06:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698