Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 730423002: Incremental compilation of superclass change. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Incremental compilation of superclass change. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41891

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged with r41889. #

Patch Set 3 : Add type arguments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -2 lines) Patch
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 5 chunks +62 lines, -2 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
6 years, 1 month ago (2014-11-18 15:15:52 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/730423002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/730423002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode462 dart/pkg/dart2js_incremental/lib/library_updater.dart:462: Set changedClasses = new Set(); Add type argument.
6 years, 1 month ago (2014-11-19 12:52:57 UTC) #3
ahe
Committed patchset #3 (id:60001) manually as 41891 (presubmit successful).
6 years, 1 month ago (2014-11-21 10:11:42 UTC) #5
ahe
6 years, 1 month ago (2014-11-21 10:12:25 UTC) #6
Message was sent while issue was closed. 
Thank you, Johnni!

https://codereview.chromium.org/730423002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/730423002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/library_updater.dart:462: Set changedClasses =
new Set();
On 2014/11/19 12:52:57, Johnni Winther wrote:
> Add type argument.

Done.

Powered by Google App Engine
This is Rietveld 408576698