Issue 72923002: Add Dart keyword symbols to the VM isolate

Issue 72923002: Add Dart keyword symbols to the VM isolate (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
regis, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add Dart keyword symbols to the VM isolate Remove the keyword symbol table from object store, and remove keyword table initialization from Scanner constructor. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=30285

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -65 lines)			Patch
M	runtime/vm/dart.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/object_store.h	View		2 chunks	+3 lines, -8 lines	1 comment	Download
M	runtime/vm/object_store.cc	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	runtime/vm/scanner.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1	5 chunks	+12 lines, -31 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.cc	View	1	4 chunks	+27 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/72923002/diff/30002/runtime/vm/object_store.h File runtime/vm/object_store.h (right): https://codereview.chromium.org/72923002/diff/30002/runtime/vm/object_store.h#newcode485 runtime/vm/object_store.h:485: return reinterpret_cast<RawObject**>(&handle_message_function_); Oops :-)

7 years, 1 month ago (2013-11-14 18:37:28 UTC) #2

hausner

Committed patchset #2 manually as r30285 (presubmit successful).

7 years, 1 month ago (2013-11-14 19:14:23 UTC) #3

Ivan Posva

DBC -ip https://codereview.chromium.org/72923002/diff/30002/runtime/vm/symbols.cc File runtime/vm/symbols.cc (right): https://codereview.chromium.org/72923002/diff/30002/runtime/vm/symbols.cc#newcode54 runtime/vm/symbols.cc:54: const intptr_t keyword_id = Symbols::kABSTRACTId + kw_index; ...

7 years, 1 month ago (2013-11-14 19:37:56 UTC) #4

hausner

7 years, 1 month ago (2013-11-14 19:41:42 UTC) #5

Message was sent while issue was closed.

Good point, thanks.

https://codereview.chromium.org/72923002/diff/30002/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/72923002/diff/30002/runtime/vm/symbols.cc#new...
runtime/vm/symbols.cc:54: const intptr_t keyword_id = Symbols::kABSTRACTId +
kw_index;
On 2013/11/14 19:37:57, Ivan Posva wrote:
> This should all be based on kKwTableStart if I am not mistaken.

Yes. The kABSTRACTId is a left-over from before I had kKwTableStart. Will fix in
a subsequent cl.

Expand Messages | Collapse Messages