Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 729193002: add code completion cache (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add code completion cache - generic mechanism for use in a subsequent CL - minor get_handler import cleanup BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41778

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -28 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 4 chunks +15 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 3 chunks +50 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-11-15 18:46:10 UTC) #2
scheglov
lgtm
6 years, 1 month ago (2014-11-16 22:17:22 UTC) #3
danrubel
6 years, 1 month ago (2014-11-17 15:14:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698