Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 728863005: Teach LoadOptimizer to interblock multi-indirection redundancies in one pass. (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
6 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Teach LoadOptimizer to handle intrablock multi-indirection redundancies in one pass. Do this by renumbering loads as we move forward. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41779

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 7 chunks +18 lines, -7 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-11-17 12:28:26 UTC) #1
Florian Schneider
lgtm https://codereview.chromium.org/728863005/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/728863005/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode5644 runtime/vm/flow_graph_optimizer.cc:5644: bool IsStore(Instruction* instr, BitVector** killed) { The name ...
6 years, 1 month ago (2014-11-17 12:46:03 UTC) #2
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-11-17 15:34:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698