Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 728513002: Remove some (but not all) unused methods in analyzer. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove some (but not all) unused methods in analyzer. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41721

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -136 lines) Patch
M pkg/analyzer/lib/src/error.dart View 2 chunks +8 lines, -9 lines 2 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +0 lines, -38 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +0 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 1 month ago (2014-11-13 16:24:55 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/728513002/diff/1/pkg/analyzer/lib/src/error.dart File pkg/analyzer/lib/src/error.dart (right): https://codereview.chromium.org/728513002/diff/1/pkg/analyzer/lib/src/error.dart#newcode96 pkg/analyzer/lib/src/error.dart:96: //class _ContentReceiver implements Source_ContentReceiver { We should be ...
6 years, 1 month ago (2014-11-13 16:51:56 UTC) #2
scheglov
https://codereview.chromium.org/728513002/diff/1/pkg/analyzer/lib/src/error.dart File pkg/analyzer/lib/src/error.dart (right): https://codereview.chromium.org/728513002/diff/1/pkg/analyzer/lib/src/error.dart#newcode96 pkg/analyzer/lib/src/error.dart:96: //class _ContentReceiver implements Source_ContentReceiver { On 2014/11/13 16:51:56, Brian ...
6 years, 1 month ago (2014-11-13 17:07:10 UTC) #3
scheglov
6 years, 1 month ago (2014-11-13 17:08:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698