Issue 728503003: Report HintCode.UNUSED_FIELD

Issue 728503003: Report HintCode.UNUSED_FIELD (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report HintCode.UNUSED_FIELD There are two positives in dart2js, valid as I can see. There are several positives in analyzer and analysis_server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41727

Patch Set 1 #

Total comments: 2

Patch Set 2 : One more test #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -20 lines)			Patch
M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View		5 chunks	+66 lines, -14 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1	3 chunks	+186 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/728503003/diff/1/pkg/analyzer/test/generated/resolver_test.dart File pkg/analyzer/test/generated/resolver_test.dart (right): https://codereview.chromium.org/728503003/diff/1/pkg/analyzer/test/generated/resolver_test.dart#newcode3984 pkg/analyzer/test/generated/resolver_test.dart:3984: void test_unusedField_isUsed_reference_qualified_unresolved() { Perhaps a test like: class ...

6 years, 1 month ago (2014-11-13 21:54:50 UTC) #2

scheglov

Committed patchset #2 (id:20001) manually as 41727 (presubmit successful).

6 years, 1 month ago (2014-11-13 23:12:47 UTC) #3

scheglov

6 years, 1 month ago (2014-11-13 23:13:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/728503003/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/728503003/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/resolver_test.dart:3984: void
test_unusedField_isUsed_reference_qualified_unresolved() {
On 2014/11/13 21:54:49, Brian Wilkerson wrote:
> Perhaps a test like:
> 
> class A {
>   int _f;
>   int m() => _f;
> }

Done.

Expand Messages | Collapse Messages