Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 728143002: only wait for analysis if necessary when computing invocation suggestions (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

only wait for analysis if necessary when computing invocation suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41760

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -76 lines) Patch
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 1 chunk +90 lines, -67 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 3 chunks +44 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-11-15 02:57:07 UTC) #2
scheglov
lgtm
6 years, 1 month ago (2014-11-15 03:13:59 UTC) #3
danrubel
6 years, 1 month ago (2014-11-15 15:17:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698