Issue 727763003: Remove unused fields in analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 727763003: Remove unused fields in analyzer. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove unused fields in analyzer. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41742

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -78 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	pkg/analyzer/lib/src/services/formatter_impl.dart	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest.dart	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	3 chunks	+1 line, -25 lines	0 comments	Download
M	pkg/analyzer/test/services/test_utils.dart	View	2 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 41742 (presubmit successful).

6 years, 1 month ago (2014-11-14 15:43:45 UTC) #3

Paul Berry

On 2014/11/14 15:43:45, scheglov wrote: > Committed patchset #1 (id:1) manually as 41742 (presubmit successful). ...

6 years, 1 month ago (2014-11-14 17:48:34 UTC) #4

scheglov

6 years, 1 month ago (2014-11-14 18:50:23 UTC) #5

Message was sent while issue was closed.

On 2014/11/14 17:48:34, Paul Berry wrote:
> On 2014/11/14 15:43:45, scheglov wrote:
> > Committed patchset #1 (id:1) manually as 41742 (presubmit successful).
> 
> It looks like this broke pkg/analyzer/test/services/formatter_test.  Repro:
> python tools/test.py --checked -mrelease -t60
> pkg/analyzer/test/services/formatter_test

Fix CL https://codereview.chromium.org/724093007

Expand Messages | Collapse Messages