Issue 72643002: Make native implementation classes for classes that are used as targets in @MirrorsUsed available f…

Issue 72643002: Make native implementation classes for classes that are used as targets in @MirrorsUsed available f… (Closed)

Created:
7 years, 1 month ago by karlklose

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org, ahe, dgrove, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make native implementation classes for classes that are used as targets in @MirrorsUsed available for reflection. This CL also adds @MirrorsUsed to the angular-todo sample. R=ahe@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=30299

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address comments. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -17 lines)			Patch
M	samples/third_party/angular_todo/main.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	4 chunks	+25 lines, -14 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/mirrors_used_native_test.dart	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

LGTM https://codereview.chromium.org/72643002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/72643002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1297 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1297: Element getDartClass(Element element) { We have the reverse ...

7 years, 1 month ago (2013-11-14 19:14:19 UTC) #3

karlklose

Thanks Johnni and Peter! I added a test. https://codereview.chromium.org/72643002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/72643002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1297 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1297: Element ...

7 years, 1 month ago (2013-11-15 08:44:52 UTC) #4

karlklose

7 years, 1 month ago (2013-11-15 08:56:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r30299 (presubmit successful).

Expand Messages | Collapse Messages