Compute more accurate bound on expected work when tracing.

Compute more accurate bound on expected work when tracing.

BUG=
R=floitsch@google.com, sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41795

[herhut, 2014-11-17 14:27:19]

This fixes a regression in Navier Stokes.

[floitsch, 2014-11-17 14:52:57]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-11-17 14:52:57]

LGTM.

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
pkg/compiler/lib/src/inferrer/node_tracer.dart:109: if (seenSoFar + users.length
<= MAX_ANALYSIS_COUNT) return false;
users is an iterable.
By asking `.length` you run through it. You might end up running through it
twice.

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
pkg/compiler/lib/src/inferrer/node_tracer.dart:110: int actualWork =
users.fold(0, (sum, user) {
I think I would have gone with a simple `for` loop, but that got me thinking...
In the end I think a simple `where` is the most intuitive.

int actualWork = users
    .where((User user) => analyzedElements.contains(user.owner))
    .length;

[herhut, 2014-11-17 15:08:45]

Patchset #2 (id:20001) has been deleted

[herhut, 2014-11-17 15:12:04]

Patchset #2 (id:40001) has been deleted

[herhut, 2014-11-17 15:12:45]

Thanks!

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
pkg/compiler/lib/src/inferrer/node_tracer.dart:109: if (seenSoFar + users.length
<= MAX_ANALYSIS_COUNT) return false;
On 2014/11/17 14:52:57, floitsch wrote:
> users is an iterable.
> By asking `.length` you run through it. You might end up running through it
> twice.

Actually, it is a Set. I just used Iterable because that is all I needed wrt.
functionality. I have exposed it as a Set now.

https://codereview.chromium.org/726383003/diff/1/pkg/compiler/lib/src/inferre...
pkg/compiler/lib/src/inferrer/node_tracer.dart:110: int actualWork =
users.fold(0, (sum, user) {
On 2014/11/17 14:52:57, floitsch wrote:
> I think I would have gone with a simple `for` loop, but that got me
thinking...
> In the end I think a simple `where` is the most intuitive.
> 
> int actualWork = users
>     .where((User user) => analyzedElements.contains(user.owner))
>     .length;

Nice. Done.

[herhut, 2014-11-18 09:39:22]

Committed patchset #2 (id:60001) manually as 41795 (presubmit successful).