Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 725543002: Renumber enum constants in analyzer to be consecutive. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Renumber enum constants in analyzer to be consecutive. There is a unit test that expects them to be consecutive. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
A unit test requires the enum numbers to be consecutive. r41696 removed one of the ...
6 years, 1 month ago (2014-11-13 10:53:17 UTC) #2
ricow1
lgtm
6 years, 1 month ago (2014-11-13 10:58:42 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 41710 (presubmit successful).
6 years, 1 month ago (2014-11-13 11:58:40 UTC) #4
scheglov
6 years, 1 month ago (2014-11-13 14:49:41 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698