Issue 21612. Support for multiple returns in the 'Extract Method' refactoring.

Issue 21612. Support for multiple returns in the 'Extract Method' refactoring.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21612

Committed: https://code.google.com/p/dart/source/detail?r=41758

[Brian Wilkerson, 2014-11-15 01:32:39]

LGTM

https://codereview.chromium.org/725393002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
(right):

https://codereview.chromium.org/725393002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:1116:
returnType = returnType.getLeastUpperBound(type);
I'm going to guess that this doesn't work very well in the same cases where the
conditional operator confuses people. Consider adding back the method
InterfaceTypeImpl.leastUpperBound or some variation of it (it was deleted from
the Dart code but still exists in the Java code).

[scheglov, 2014-11-15 01:41:01]

Committed patchset #1 (id:1) manually as 41758 (presubmit successful).

[scheglov, 2014-11-15 02:26:16]

https://codereview.chromium.org/725393002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
(right):

https://codereview.chromium.org/725393002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:1116:
returnType = returnType.getLeastUpperBound(type);
On 2014/11/15 01:32:38, Brian Wilkerson wrote:
> I'm going to guess that this doesn't work very well in the same cases where
the
> conditional operator confuses people. Consider adding back the method
> InterfaceTypeImpl.leastUpperBound or some variation of it (it was deleted from
> the Dart code but still exists in the Java code).

OK
https://codereview.chromium.org/730803003