Add support for if, while, break, continue to js-cps

Add support for if, while, break, continue to js-cps

Also avoid returning values via fields in CodeGenerator.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41946

[sigurdm, 2014-11-24 10:36:49]

Patchset #1 (id:1) has been deleted

[sigurdm, 2014-11-24 10:57:56]

Patchset #1 (id:20001) has been deleted

[sigurdm, 2014-11-24 11:42:22]

sigurdm@google.com changed reviewers:
+ floitsch@google.com, karlklose@chromium.org

[floitsch, 2014-11-24 16:37:47]

LGTM.

https://codereview.chromium.org/725293004/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/725293004/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:282: ? new
js.EmptyStatement()
why?
looks like just "elseStatement" would do it.

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart (right):

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart:40: while
(P.identical(V.foo(true), true))
That will annoy us when we do optimizations.
I'm not sure if we want to do something about it now, or later, though.

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:9: import 'dart:math';
why?

[sigurdm, 2014-11-25 08:29:51]

https://codereview.chromium.org/725293004/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/725293004/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:282: ? new
js.EmptyStatement()
On 2014/11/24 16:37:47, floitsch wrote:
> why?
> looks like just "elseStatement" would do it.

Right - I had a null check here, but it was unnecessary.
Removed

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart (right):

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart:40: while
(P.identical(V.foo(true), true))
On 2014/11/24 16:37:47, floitsch wrote:
> That will annoy us when we do optimizations.
> I'm not sure if we want to do something about it now, or later, though.

Acknowledged.

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/725293004/diff/60001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:9: import 'dart:math';
On 2014/11/24 16:37:47, floitsch wrote:
> why?

I used it for debugging.
Removed.

[sigurdm, 2014-11-25 08:30:15]

Committed patchset #3 (id:80001) manually as 41946 (presubmit successful).