Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 724723003: use shared code transformer, update web_components to remove .map and .concat files (Closed)

Created:
6 years, 1 month ago by jakemac
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

use shared code transformer, update web_components to remove .map and .concat files This is a redo of https://codereview.chromium.org/540633002/ because I had deleted my local branch and didn't know how to recover it. Committed: https://code.google.com/p/dart/source/detail?r=41724

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -87 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 1 comment Download
D pkg/polymer/lib/src/build/delete_file.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/polymer/lib/src/build/remove_sourcemap_comment.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +3 lines, -3 lines 0 comments Download
D pkg/polymer/test/build/remove_sourcemap_comment_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
M pkg/web_components/CHANGELOG.md View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/web_components/pubspec.yaml View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jakemac
Committed patchset #1 (id:1) manually as 41724 (presubmit successful).
6 years, 1 month ago (2014-11-13 17:47:38 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 1 month ago (2014-11-13 20:55:50 UTC) #3
Siggi Cherem (dart-lang)
FYI https://codereview.chromium.org/724723003/diff/1/pkg/polymer/CHANGELOG.md File pkg/polymer/CHANGELOG.md (right): https://codereview.chromium.org/724723003/diff/1/pkg/polymer/CHANGELOG.md#newcode2 pkg/polymer/CHANGELOG.md:2: * Increase code_transformers lower bound and use shared ...
6 years, 1 month ago (2014-11-13 20:56:42 UTC) #4
jakemac
On 2014/11/13 20:56:42, Siggi Cherem (dart-lang) wrote: > FYI > > https://codereview.chromium.org/724723003/diff/1/pkg/polymer/CHANGELOG.md > File pkg/polymer/CHANGELOG.md ...
6 years, 1 month ago (2014-11-13 21:03:37 UTC) #5
Siggi Cherem (dart-lang)
6 years, 1 month ago (2014-11-13 23:34:43 UTC) #6
Message was sent while issue was closed.
On 2014/11/13 21:03:37, jakemac wrote:
> On 2014/11/13 20:56:42, Siggi Cherem (dart-lang) wrote:
> > FYI
> > 
> > https://codereview.chromium.org/724723003/diff/1/pkg/polymer/CHANGELOG.md
> > File pkg/polymer/CHANGELOG.md (right):
> > 
> >
>
https://codereview.chromium.org/724723003/diff/1/pkg/polymer/CHANGELOG.md#new...
> > pkg/polymer/CHANGELOG.md:2: * Increase code_transformers lower bound and use
> > shared transformers from it.
> > seems that you didn't have to increase the lowerbound after all.
> 
> Oh true, I think probably its best to just update the changelog but not bump
the
> version so it will just get updated the next time we release? I don't know of
> another good solution here

yeah, that sounds good

Powered by Google App Engine
This is Rietveld 408576698