Make toString visible on enum classes, as required by proposed spec.

Make toString visible on enum classes, as required by proposed spec.

R=hausner@google.com, rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41939

[koda, 2014-11-24 19:05:46]

The relevant wording of sec 13 of the spec proposal is:

"has the same effect as a class declaration
...
String toString() => ..."

In particular, it should be possible to invoke this toString method via
reflection.

[rmacnak, 2014-11-24 19:06:29]

lgtm

https://codereview.chromium.org/724373003/diff/20001/tests/language/enum_to_s...
File tests/language/enum_to_string_test.dart (right):

https://codereview.chromium.org/724373003/diff/20001/tests/language/enum_to_s...
tests/language/enum_to_string_test.dart:15: var name =
reflect(Foo.BAR).invoke(const Symbol('toString'), []).reflectee;
A symbol literal is preferred - #toString

[hausner, 2014-11-24 19:08:30]

lgtm

LGTM.

How about renaming the test to reflect that it's a mirrors test? (No pun
intended.) It could then be expanded later to check other mirror-related
functionality for enum types.

[koda, 2014-11-24 19:18:49]

hausner: I wouldn't consider it a test of the mirrors system itself, but rather
a test of enum behavior that can (only?) be observed through reflection.

Still, I agree with you that there might be a need to extend it in the future,
so, I kept it in language/ but renamed it "enum_mirror_test".

https://codereview.chromium.org/724373003/diff/20001/tests/language/enum_to_s...
File tests/language/enum_to_string_test.dart (right):

https://codereview.chromium.org/724373003/diff/20001/tests/language/enum_to_s...
tests/language/enum_to_string_test.dart:15: var name =
reflect(Foo.BAR).invoke(const Symbol('toString'), []).reflectee;
On 2014/11/24 19:06:28, rmacnak wrote:
> A symbol literal is preferred - #toString

Done.

[koda, 2014-11-24 19:19:23]

Committed patchset #4 (id:60001) manually as r41939 (presubmit successful).