Report HintCode.UNUSED_ELEMENT for non-synthetic property accessors.

Report HintCode.UNUSED_ELEMENT for non-synthetic property accessors.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41723

[Brian Wilkerson, 2014-11-13 17:12:34]

LGTM

https://codereview.chromium.org/724113002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/724113002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/resolver_test.dart:3373: var v = _g;
I assume that we will eventually generate a hint for 'v', so you might want to
guard against having this test start to fail by adding a use of 'v' now. (Also
for the next three tests.)

[scheglov, 2014-11-13 17:14:43]

https://codereview.chromium.org/724113002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/724113002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/resolver_test.dart:3373: var v = _g;
On 2014/11/13 17:12:34, Brian Wilkerson wrote:
> I assume that we will eventually generate a hint for 'v', so you might want to
> guard against having this test start to fail by adding a use of 'v' now. (Also
> for the next three tests.)

We have a lot of tests like this, that don't use declared local variables.
But we check for HintCode.UNUSED_LOCAL_VARIABLE only when
enableUnusedLocalVariable is "true".

[scheglov, 2014-11-13 17:16:17]

Committed patchset #1 (id:1) manually as 41723 (presubmit successful).