Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 724093007: Prevent CodeKind constants from being canonicalized. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix formatter breakage. Constants are special. R=paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41748

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 chunk +5 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
scheglov
6 years, 1 month ago (2014-11-14 18:49:57 UTC) #1
Paul Berry
Change lgtm. I would appreciate a more descriptive commit message, though. How about: "prevent CodeKind ...
6 years, 1 month ago (2014-11-14 18:56:20 UTC) #2
scheglov
On 2014/11/14 18:56:20, Paul Berry wrote: > Change lgtm. > > I would appreciate a ...
6 years, 1 month ago (2014-11-14 19:13:15 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/724093007/diff/1/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/724093007/diff/1/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode62 pkg/analyzer/lib/src/services/formatter_impl.dart:62: final int ordinal; Alternatively, we could give them a ...
6 years, 1 month ago (2014-11-14 19:16:15 UTC) #5
scheglov
6 years, 1 month ago (2014-11-14 19:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698