Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 724013002: Update status for fixed test. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status for fixed test. BUG=dartbug.com/21582 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41712

Patch Set 1 #

Patch Set 2 : Add failing java analyzer test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/corelib/corelib.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
6 years, 1 month ago (2014-11-13 12:11:44 UTC) #2
Johnni Winther
lgtm
6 years, 1 month ago (2014-11-13 12:50:17 UTC) #3
Bill Hesse
Committed patchset #2 (id:20001) manually as 41712 (presubmit successful).
6 years, 1 month ago (2014-11-13 13:14:47 UTC) #4
Bill Hesse
PTAL - added test that fails on the Java dartanalyzer, because of Dart VM defines: ...
6 years, 1 month ago (2014-11-13 13:14:57 UTC) #5
Johnni Winther
6 years, 1 month ago (2014-11-14 10:13:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698