Issue 723963006: Specialize _toPow2String for bigint to make it linear instead of quadratic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723963006: Specialize _toPow2String for bigint to make it linear instead of quadratic. (Closed)

Created:
6 years, 1 month ago by regis

Modified:
6 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Specialize _toPow2String for bigint to make it linear instead of quadratic. Remove some duplicated bigint corelib tests. Cleanup corelib tests status file. Partially fix issue 20879 (not closed). R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=41728

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -905 lines)			Patch
M	runtime/lib/bigint.dart	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	runtime/lib/integers.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/corelib/big_integer_parsed_arith_vm_test.dart	View	3 chunks	+0 lines, -891 lines	0 comments	Download
M	tests/corelib/big_integer_parsed_div_rem_vm_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

regis

6 years, 1 month ago (2014-11-13 23:54:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41728 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages